Hisoka-X commented on code in PR #5872:
URL: https://github.com/apache/seatunnel/pull/5872#discussion_r1426241555
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/Column.java:
##########
@@ -58,21 +78,57 @@ public abstract class Column implements Serializable {
/** Field type in the database * */
protected final String sourceType;
- /** Unsigned bit * */
- protected final boolean isUnsigned;
+ /** your options * */
Review Comment:
What's meaning of `your options`?
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/Column.java:
##########
@@ -44,7 +46,25 @@ public abstract class Column implements Serializable {
// todo: use generic type
protected final SeaTunnelDataType<?> dataType;
- protected final Integer columnLength;
+ /**
+ * Designated column's specified column size.
+ *
+ * <p>For numeric data, this is the maximum precision. For character data,
this is the length in
+ * char. For binary data, this is the length in bytes.
+ *
+ * <p>Null is returned for data types where the scale is not applicable.
+ */
+ protected final Long columnLength;
Review Comment:
The length not max value, would it over Integer.MAX_VALUE ?
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/converter/BasicTypeConverter.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.api.table.converter;
+
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.api.table.catalog.Column;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+public interface BasicTypeConverter<T extends BasicTypeDefine> extends
TypeConverter<T> {
+
+ default List<T> reconvert(CatalogTable table, String... identifiers) {
Review Comment:
please add some comment on this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
