Hisoka-X commented on code in PR #5939:
URL: https://github.com/apache/seatunnel/pull/5939#discussion_r1410587080
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -67,7 +67,7 @@ public class HttpConfig {
public static final Option<ResponseFormat> FORMAT =
Options.key("format")
.enumType(ResponseFormat.class)
- .defaultValue(ResponseFormat.JSON)
+ .noDefaultValue()
Review Comment:
I think you should not change the default value of `format`. Because it only
worked when user configure Http source with `schema` config. Please refer
https://github.com/apache/seatunnel/pull/5939/files#diff-7c704c6a3927123b31b41483102f286339da3832309810496f19410c2548f06fR118-R150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
