Re: [PR] [BUG][Connector-V2][Http] fix bug http config no schema option and improve e2e test add case [seatunnel]

Thu, 30 Nov 2023 18:19:53 -0800 


jackyyyyyssss commented on code in PR #5939:
URL: https://github.com/apache/seatunnel/pull/5939#discussion_r1411523846


##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -67,7 +67,7 @@ public class HttpConfig {
     public static final Option<ResponseFormat> FORMAT =
             Options.key("format")
                     .enumType(ResponseFormat.class)
-                    .defaultValue(ResponseFormat.JSON)
+                    .noDefaultValue()

Review Comment:
   
![image](https://github.com/apache/seatunnel/assets/127465317/a872bc99-5cbf-480b-a1ca-bcc6612ca586)
   Removing the default value of JSON is due to validation causing it to never 
run until there is no schema to take a branch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to