liunaijie commented on code in PR #6657:
URL: https://github.com/apache/seatunnel/pull/6657#discussion_r1555287118
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkFactory.java:
##########
@@ -39,17 +36,9 @@ public String factoryIdentifier() {
@Override
public OptionRule optionRule() {
return OptionRule.builder()
- .required(Config.FORMAT, Config.BOOTSTRAP_SERVERS)
- .conditional(
Review Comment:
because i find this rule is only check `topic` parameter exist when format
is in (json, cancal_json, text, ....), but it required whether the format is.
so i remove it.
if the web need use this, i will add this `conditional` option back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
