liunaijie commented on code in PR #6657:
URL: https://github.com/apache/seatunnel/pull/6657#discussion_r1559172634
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkFactory.java:
##########
@@ -39,23 +39,26 @@ public String factoryIdentifier() {
@Override
public OptionRule optionRule() {
return OptionRule.builder()
- .required(Config.FORMAT, Config.BOOTSTRAP_SERVERS)
- .conditional(
- Config.FORMAT,
- Arrays.asList(
- MessageFormat.JSON,
- MessageFormat.CANAL_JSON,
- MessageFormat.TEXT,
- MessageFormat.OGG_JSON,
- MessageFormat.AVRO),
- Config.TOPIC)
+ .required(Config.TOPIC, Config.BOOTSTRAP_SERVERS)
.optional(
+ Config.FORMAT,
Config.KAFKA_CONFIG,
Config.ASSIGN_PARTITIONS,
Config.TRANSACTION_PREFIX,
Config.SEMANTICS,
Config.PARTITION,
Config.PARTITION_KEY_FIELDS)
+ .conditional(
Review Comment:
move topic to required check. if in the conditional, it only required when
format type is in the list. if other format is add and using this format, it
doesn't required topic parameter, then in the next steps will get exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
