dailai commented on code in PR #6679:
URL: https://github.com/apache/seatunnel/pull/6679#discussion_r1561893058
##########
seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java:
##########
@@ -153,6 +162,12 @@ public static String getCreateTableStatement(
rowTypeFields);
}
+ private static boolean canHandledByDefaultTemplate(String createTemplate,
String primaryKey) {
+ return StringUtils.equals(
+ createTemplate,
DorisOptions.SAVE_MODE_CREATE_TEMPLATE.defaultValue())
+ && StringUtils.isBlank(primaryKey);
+ }
Review Comment:
My intention is to do so, because the relationship of time I made the
simplest. I'm going to take some time to do that.
##########
seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java:
##########
@@ -153,6 +162,12 @@ public static String getCreateTableStatement(
rowTypeFields);
}
+ private static boolean canHandledByDefaultTemplate(String createTemplate,
String primaryKey) {
+ return StringUtils.equals(
+ createTemplate,
DorisOptions.SAVE_MODE_CREATE_TEMPLATE.defaultValue())
+ && StringUtils.isBlank(primaryKey);
+ }
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
