dailai commented on code in PR #6679:
URL: https://github.com/apache/seatunnel/pull/6679#discussion_r1562152705
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java:
##########
@@ -17,13 +17,24 @@
package org.apache.seatunnel.api.sink;
-public class SaveModeConstants {
+public enum SaveModePlaceHolderEnum {
+ ROWTYPE_PRIMARY_KEY("primaryKeys"),
+ ROWTYPE_UNIQUE_KEY("uniqueKeys"),
+ ROWTYPE_FIELDS("fields"),
+ TABLE_NAME("tableName"),
+ DATABASE("database");
Review Comment:
> Please do not change the key value. We need to ensure backward
compatibility
There are already methods in the class to get the placeholder, the
enumeration names are the same as before, and the keyValue here is used for
other purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
