Hisoka-X commented on code in PR #6767:
URL: https://github.com/apache/seatunnel/pull/6767#discussion_r1594911518
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java:
##########
@@ -87,6 +90,14 @@ public static SeaTunnelRuntimeException
writeSeaTunnelRowFailed(
return new SeaTunnelRuntimeException(WRITE_SEATUNNEL_ROW_ERROR,
params, cause);
}
+ public static SeaTunnelRuntimeException unsupportedDataType(
+ String identifier, String dataType) {
+ Map<String, String> params = new HashMap<>();
+ params.put("identifier", identifier);
+ params.put("dataType", dataType);
+ return new SeaTunnelRuntimeException(UNSUPPORTED_DATA_TYPE_SIMPLE,
params);
+ }
Review Comment:
Please reuse `public static SeaTunnelRuntimeException unsupportedDataType(
String identifier, String dataType, String field) `. Because we
should make sure user know which field can not supported.
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java:
##########
@@ -199,4 +210,19 @@ public static SeaTunnelRuntimeException
sqlTemplateHandledError(
params.put("optionName", optionName);
return new SeaTunnelRuntimeException(SQL_TEMPLATE_HANDLED_ERROR,
params);
}
+
+ public static SeaTunnelRuntimeException unsupportedArrayGenericType(
+ String identifier, String dataType) {
+ Map<String, String> params = new HashMap<>();
+ params.put("identifier", identifier);
+ params.put("dataType", dataType);
+ return new SeaTunnelRuntimeException(UNSUPPORTED_ARRAY_GENERIC_TYPE,
params);
+ }
+
+ public static SeaTunnelRuntimeException unsupportedRowKind(String
identifier, String rowKind) {
Review Comment:
we need tableId when invoke `unsupportedRowKind` method.
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java:
##########
@@ -199,4 +210,19 @@ public static SeaTunnelRuntimeException
sqlTemplateHandledError(
params.put("optionName", optionName);
return new SeaTunnelRuntimeException(SQL_TEMPLATE_HANDLED_ERROR,
params);
}
+
+ public static SeaTunnelRuntimeException unsupportedArrayGenericType(
+ String identifier, String dataType) {
+ Map<String, String> params = new HashMap<>();
+ params.put("identifier", identifier);
+ params.put("dataType", dataType);
+ return new SeaTunnelRuntimeException(UNSUPPORTED_ARRAY_GENERIC_TYPE,
params);
+ }
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
