xiaochen-zhou commented on code in PR #6767:
URL: https://github.com/apache/seatunnel/pull/6767#discussion_r1597769048
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java:
##########
@@ -199,4 +210,19 @@ public static SeaTunnelRuntimeException
sqlTemplateHandledError(
params.put("optionName", optionName);
return new SeaTunnelRuntimeException(SQL_TEMPLATE_HANDLED_ERROR,
params);
}
+
+ public static SeaTunnelRuntimeException unsupportedArrayGenericType(
+ String identifier, String dataType) {
+ Map<String, String> params = new HashMap<>();
+ params.put("identifier", identifier);
+ params.put("dataType", dataType);
+ return new SeaTunnelRuntimeException(UNSUPPORTED_ARRAY_GENERIC_TYPE,
params);
+ }
+
+ public static SeaTunnelRuntimeException unsupportedRowKind(String
identifier, String rowKind) {
Review Comment:
> > we need tableId when invoke `unsupportedRowKind` method.
>
> OK, I will optimize the code based on your suggestions
done.
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java:
##########
@@ -199,4 +210,19 @@ public static SeaTunnelRuntimeException
sqlTemplateHandledError(
params.put("optionName", optionName);
return new SeaTunnelRuntimeException(SQL_TEMPLATE_HANDLED_ERROR,
params);
}
+
+ public static SeaTunnelRuntimeException unsupportedArrayGenericType(
+ String identifier, String dataType) {
+ Map<String, String> params = new HashMap<>();
+ params.put("identifier", identifier);
+ params.put("dataType", dataType);
+ return new SeaTunnelRuntimeException(UNSUPPORTED_ARRAY_GENERIC_TYPE,
params);
+ }
Review Comment:
> ditto
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
