dailai commented on code in PR #7335:
URL: https://github.com/apache/seatunnel/pull/7335#discussion_r1708238389
##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-13/src/main/java/org/apache/seatunnel/translation/flink/sink/FlinkSinkWriterContext.java:
##########
@@ -50,6 +50,11 @@ public int getIndexOfSubtask() {
return writerContext.getSubtaskId();
}
+ @Override
+ public int getNumberOfParallelSubtasks() {
Review Comment:
Please do not return 0 directly, if this is not necessary to implement,
please give a default implementation in the interface, do not implement it here.
##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/sink/FlinkSinkWriterContext.java:
##########
@@ -47,6 +47,11 @@ public int getIndexOfSubtask() {
return writerContext.getSubtaskId();
}
+ @Override
+ public int getNumberOfParallelSubtasks() {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
