Hisoka-X commented on code in PR #7335:
URL: https://github.com/apache/seatunnel/pull/7335#discussion_r1740268349


##########
docs/en/connector-v2/sink/Paimon.md:
##########
@@ -241,6 +241,88 @@ sink {
 }
 ```
 
+### Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1

Review Comment:
   Also please add comment for this feature only worked on zeta.



##########
docs/en/connector-v2/sink/Paimon.md:
##########
@@ -241,6 +241,88 @@ sink {
 }
 ```
 
+### Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1

Review Comment:
   ```suggestion
   ### Write to dynamic bucket table
   Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1
   ```



##########
docs/en/connector-v2/sink/Paimon.md:
##########
@@ -241,6 +241,88 @@ sink {
 }
 ```
 
+### Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1
+
+#### core 
options:[reference](https://paimon.apache.org/docs/0.8/primary-key-table/data-distribution/#dynamic-bucket)
+
+|              name              | type | required | default values |          
        Description                   |
+|--------------------------------|------|----------|----------------|------------------------------------------------|
+| dynamic-bucket.target-row-num  | long | 是        | 2000000L       | controls 
the target row number for one bucket. |
+| dynamic-bucket.initial-buckets | int  | 否        |                | controls 
the number of initialized bucket.     |

Review Comment:
   Change chinese to english.



##########
docs/en/connector-v2/sink/Paimon.md:
##########
@@ -241,6 +241,88 @@ sink {
 }
 ```
 
+### Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1
+
+#### core 
options:[reference](https://paimon.apache.org/docs/0.8/primary-key-table/data-distribution/#dynamic-bucket)
+
+|              name              | type | required | default values |          
        Description                   |
+|--------------------------------|------|----------|----------------|------------------------------------------------|
+| dynamic-bucket.target-row-num  | long | 是        | 2000000L       | controls 
the target row number for one bucket. |
+| dynamic-bucket.initial-buckets | int  | 否        |                | controls 
the number of initialized bucket.     |
+
+```hocon
+env {
+  parallelism = 1
+  job.mode = "STREAMING"
+  checkpoint.interval = 5000
+}
+
+source {
+  Mysql-CDC {
+    base-url = "jdbc:mysql://127.0.0.1:3306/seatunnel"
+    username = "root"
+    password = "******"
+    table-names = ["seatunnel.role"]
+  }
+}
+
+sink {
+  Paimon {
+    catalog_name="seatunnel_test"
+    warehouse="file:///tmp/seatunnel/paimon/hadoop-sink/"
+    database="seatunnel"
+    table="role"
+    paimon.table.write-props = {
+        bucket = -1
+        dynamic-bucket.target-row-num = 50000
+    }
+    paimon.table.partition-keys = "dt"
+    paimon.table.primary-keys = "pk_id,dt"
+  }
+}
+```
+
+### Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1
+
+#### core 
options:[reference](https://paimon.apache.org/docs/0.8/primary-key-table/data-distribution/#dynamic-bucket)
+
+|              name              | type | required | default values |          
        Description                   |
+|--------------------------------|------|----------|----------------|------------------------------------------------|
+| dynamic-bucket.target-row-num  | long | 是        | 2000000L       | controls 
the target row number for one bucket. |
+| dynamic-bucket.initial-buckets | int  | 否        |                | controls 
the number of initialized bucket.     |
+
+```hocon
+env {
+  parallelism = 1
+  job.mode = "STREAMING"
+  checkpoint.interval = 5000
+}
+
+source {
+  Mysql-CDC {
+    base-url = "jdbc:mysql://127.0.0.1:3306/seatunnel"
+    username = "root"
+    password = "******"
+    table-names = ["seatunnel.role"]
+  }
+}
+
+sink {
+  Paimon {
+    catalog_name="seatunnel_test"
+    warehouse="file:///tmp/seatunnel/paimon/hadoop-sink/"
+    database="seatunnel"

Review Comment:
   It's duplicated?



##########
docs/en/connector-v2/sink/Paimon.md:
##########
@@ -43,7 +43,7 @@ libfb303-xxx.jar
 | data_save_mode              | Enum   | No       | APPEND_DATA                
  | The data save mode                                                          
                                                                                
     |
 | paimon.table.primary-keys   | String | No       | -                          
  | Default comma-separated list of columns (primary key) that identify a row 
in tables.(Notice: The partition field needs to be included in the primary key 
fields) |
 | paimon.table.partition-keys | String | No       | -                          
  | Default comma-separated list of partition fields to use when creating 
tables.                                                                         
           |
-| paimon.table.write-props    | Map    | No       | -                          
  | Properties passed through to paimon table initialization, 
[reference](https://paimon.apache.org/docs/master/maintenance/configurations/#coreoptions).
            |
+| paimon.table.write-props    | Map    | No       | -                          
  | Properties passed through to paimon table initialization, 
[reference](https://paimon.apache.org/docs/0.8/maintenance/configurations/#coreoptions).
               |

Review Comment:
   Please revert this change.



##########
docs/en/connector-v2/sink/Paimon.md:
##########
@@ -241,6 +241,88 @@ sink {
 }
 ```
 
+### Single dynamic bucket table with write props of paimon,operates on the 
primary key table and bucket is -1
+
+#### core 
options:[reference](https://paimon.apache.org/docs/0.8/primary-key-table/data-distribution/#dynamic-bucket)

Review Comment:
   ```suggestion
   core 
options:[reference](https://paimon.apache.org/docs/master/primary-key-table/data-distribution/#dynamic-bucket)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to