Hisoka-X commented on code in PR #7294:
URL: https://github.com/apache/seatunnel/pull/7294#discussion_r1713188900
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java:
##########
@@ -63,13 +64,17 @@ public class JdbcCatalogUtils {
private static final String DEFAULT_CATALOG_NAME = "jdbc_catalog";
public static Map<TablePath, JdbcSourceTable> getTables(
- JdbcConnectionConfig jdbcConnectionConfig,
List<JdbcSourceTableConfig> tablesConfig)
+ JdbcConnectionConfig jdbcConnectionConfig,
+ List<JdbcSourceTableConfig> tablesConfig,
+ JdbcSourceConfig sourceConfig)
Review Comment:
```
JdbcSourceConfig sourceConfig
```
change to
```
String dialectName
```
since we only use this parameter.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java:
##########
@@ -35,6 +35,13 @@ public interface JdbcOptions {
Option<String> DRIVER =
Options.key("driver").stringType().noDefaultValue().withDescription("driver");
+ Option<String> DIALECT_NAME =
+ Options.key("dialect.name")
+ .stringType()
+ .defaultValue("default")
+ .withDescription(
+ "The dialect name, when use same jdbc drive, use
this parameter to choose the special implement.");
Review Comment:
So if I use this config will not work right?
```
Jdbc {
driver = com.mysql.cj.jdbc.Driver
url = "jdbc:mysql://mysql:9030"
user = root
password = ""
query = "select * from `test`.`e2e_table_source`"
partition_column = "STRING_COL"
dialect.name = "mysql"
}
```
It's weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
