liunaijie commented on code in PR #7294:
URL: https://github.com/apache/seatunnel/pull/7294#discussion_r1713527018
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java:
##########
@@ -35,6 +35,13 @@ public interface JdbcOptions {
Option<String> DRIVER =
Options.key("driver").stringType().noDefaultValue().withDescription("driver");
+ Option<String> DIALECT_NAME =
+ Options.key("dialect.name")
+ .stringType()
+ .defaultValue("default")
+ .withDescription(
+ "The dialect name, when use same jdbc drive, use
this parameter to choose the special implement.");
Review Comment:
yes, if we support dialect.name = "mysql" then this parameter is required to
mysql connector, it will impact the current user.
and i think this feature is the special requirement, use same jdbc driver,
and the default dialect can not support some feature, it can use this parameter
to choose the corresponding dialect implement.
In this case, only those user need this feature need add this parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
