Hisoka-X commented on PR #7385:
URL: https://github.com/apache/seatunnel/pull/7385#issuecomment-2345759587

   > > Does timeplus can directly write/read by clickhouse connector? I found 
many code come from clickhouse connector.
   > 
   > Hi @Hisoka-X , yes, this timeplus connector is largely copied from the 
clickhouse connector and I added the multi-table sync and schema auto-created. 
Timeplus Proton is built with Clickhouse libraries, but we cannot use the 
clickhouse JDBC driver or HTTP Java client to read/write Timeplus, because 
there are some significantly changes:
   > 
   > * the data type in ClickHouse are UInt8, we changed them to uint8
   > * function names in Timeplus are also consolidated to to_start_of_day() 
style
   > * also Timeplus supports streaming query and historical query. Running 
`select count() from sensor` will keep sending you the new count every X 
seconds. To run a bounded query, need to run `select count() from 
table(sensor)` or use the different HTTP/TCP port to turn on historical mode.
   
   Thanks @jovezhong for explain! Could you refactor code to reuse clickhouse 
connector code? Just like our file series connectors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to