Hisoka-X commented on PR #7385: URL: https://github.com/apache/seatunnel/pull/7385#issuecomment-2347913797
> how to manage the dependency We should have three module. ``` connector-clickhouse-base (refer https://github.com/apache/seatunnel/tree/dev/seatunnel-connectors-v2/connector-file) connector-clickhouse (dependency: connector-clickhouse-base refer https://github.com/apache/seatunnel/tree/dev/seatunnel-connectors-v2/connector-file/connector-file-local) connector-timeplus (dependency: connector-clickhouse-base refer https://github.com/apache/seatunnel/tree/dev/seatunnel-connectors-v2/connector-file/connector-file-hadoop) ``` > even some private/protected method/field We can change it to public if necessary, or create abstract class. > clickhouse connector doesn't support mutli-table sync or schema auto creation So I think we should put multi-table sync and schema auto creation part into `connector-timeplus` > there are many other details I need to customize the SQL or method, more than just JDBC driver class. For example, clickhouse connector uses lower level ClickHouse HTTP Client The core is not to make timeplus dependent on the clickhouse connector, but to hope that public methods can only exist in one copy for easy maintenance. > Better to include in the built-in connector list. Yes, after refactor, we can use clickhouse and timeplus at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
