Hisoka-X commented on code in PR #7885:
URL: https://github.com/apache/seatunnel/pull/7885#discussion_r1810682504
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/BasicType.java:
##########
@@ -24,6 +24,7 @@ public class BasicType<T> implements SeaTunnelDataType<T> {
public static final BasicType<String> STRING_TYPE =
new BasicType<>(String.class, SqlType.STRING);
+ public static final BasicType<String> JSON_TYPE = new
BasicType<>(String.class, SqlType.JSON);
Review Comment:
Why not put the `json` flag into
https://github.com/apache/seatunnel/blob/4406fbc0a0516c8152df3370d37534348a0f8cc4/seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/Column.java#L86
? Just like other milvus option
https://github.com/apache/seatunnel/blob/4406fbc0a0516c8152df3370d37534348a0f8cc4/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusOptions.java#L19
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
