nianliuu commented on code in PR #7885:
URL: https://github.com/apache/seatunnel/pull/7885#discussion_r1814140879


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -35,6 +38,8 @@ public final class SeaTunnelRow implements Serializable {
 
     private volatile int size;
 
+    private String partitionName;

Review Comment:
   We read data by partition, then need to write it into same partition too. I 
guess we have to label the data with partition Name which should be put into 
SeatunnelRow.
   
   PartitionKey is a different situation, it's automatically created partition 
based in column value. While partitionName in SeatunnelRow is used for manually 
created partition.  See https://milvus.io/docs/manage-partitions.md
   
   Pinecone has similar thing called namespace. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to