lm-ylj commented on code in PR #7888:
URL: https://github.com/apache/seatunnel/pull/7888#discussion_r1817718748
##########
docs/en/connector-v2/sink/Redis.md:
##########
@@ -49,13 +52,17 @@ Upstream data is the following:
| 200 | get success | true |
| 500 | internal error | false |
-If you assign field name to `code` and data_type to `key`, two data will be
written to redis:
-1. `200 -> {code: 200, message: true, data: get success}`
-2. `500 -> {code: 500, message: false, data: internal error}`
+You can customize the Redis key using '{' and '}', and the field name in '{}'
will be parsed and replaced by the field value in the upstream data. For
example, If you assign field name to `{code}` and data_type to `key`, two data
will be written to redis:
+1. `200 -> {code: 200, data: get success, success: true}`
+2. `500 -> {code: 500, data: internal error, success: false}`
Review Comment:
If we introduce new key name, such as keyfield, it will cause users to write
two keys, namely key and keyfield, which is very easy to confuse because key is
a required field. I think we can introduce a new option to control whether
custom keys are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
