FuYouJ commented on code in PR #7888:
URL: https://github.com/apache/seatunnel/pull/7888#discussion_r1818120180


##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisConfig.java:
##########
@@ -127,6 +127,25 @@ public enum HashKeyParseMode {
                             "batch_size is used to control the size of a batch 
of data during read and write operations"
                                     + ",default 10");
 
+    public static final Option<String> VALUE_FIELD =
+            Options.key("value_field")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "The field of value you want to write to redis, 
support string list set zset");

Review Comment:
   would it be better to add end-to-end tests for all types, including string, 
list, set, and zset?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to