Hisoka-X commented on code in PR #7921:
URL: https://github.com/apache/seatunnel/pull/7921#discussion_r1818280001
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceSplitEnumerator.java:
##########
@@ -77,6 +77,8 @@ public void registerReader(int subtaskId) {
if (assigned < 0) {
assigned = subtaskId;
context.assignSplit(subtaskId, new ClickhouseSourceSplit());
+ } else {
+ context.signalNoMoreSplits(subtaskId);
}
Review Comment:
```suggestion
if (assigned < 0) {
assigned = subtaskId;
context.assignSplit(subtaskId, new ClickhouseSourceSplit());
context.signalNoMoreSplits(subtaskId);
} else {
context.signalNoMoreSplits(subtaskId);
}
```
##########
seatunnel-engine/seatunnel-engine-common/src/main/resources/seatunnel.yaml:
##########
@@ -20,6 +20,7 @@ seatunnel:
backup-count: 1
queue-type: blockingqueue
print-execution-info-interval: 60
+ print-job-metrics-info-interval: 60
Review Comment:
You can configure it in your local environment. But do not commit it. Please
revert it.
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceReader.java:
##########
@@ -97,6 +101,12 @@ record -> {
}
this.readerContext.signalNoMoreElement();
this.splits.clear();
+ } else if (noMoreSplit
+ && splits.isEmpty()
+ && Boundedness.BOUNDED.equals(readerContext.getBoundedness()))
{
+ log.info("Closed the bounded ClickHouse source");
+ this.readerContext.signalNoMoreElement();
+ this.splits.clear();
}
Review Comment:
```suggestion
this.splits.clear();
}
if (noMoreSplit
&& splits.isEmpty()
&&
Boundedness.BOUNDED.equals(readerContext.getBoundedness())) {
log.info("Closed the bounded ClickHouse source");
this.readerContext.signalNoMoreElement();
this.splits.clear();
}
```
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-clickhouse-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ClickhouseIT.java:
##########
@@ -101,6 +101,13 @@ public void testClickhouse(TestContainer container) throws
Exception {
clearSinkTable();
}
+ @TestTemplate
+ public void testSourceParallelism(TestContainer container) throws
Exception {
+ LOG.info("=========Multi parallelism testing begins===========");
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
