zhilinli123 commented on code in PR #7921:
URL: https://github.com/apache/seatunnel/pull/7921#discussion_r1820003897
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceReader.java:
##########
@@ -97,6 +101,12 @@ record -> {
}
this.readerContext.signalNoMoreElement();
this.splits.clear();
+ } else if (noMoreSplit
+ && splits.isEmpty()
+ && Boundedness.BOUNDED.equals(readerContext.getBoundedness()))
{
+ log.info("Closed the bounded ClickHouse source");
+ this.readerContext.signalNoMoreElement();
+ this.splits.clear();
}
Review Comment:
> Keep it for now. The purpose of keeping it is to unify the processing
logic of most connectors, to facilitate reference for other developers and
reduce the chance of bugs.
What if the user uses processing mode to write STREAMING? It's unnecessary
code and I think it's better to get rid of it Developers adding features are
certainly familiar with their read patterns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
