Hisoka-X commented on code in PR #7928:
URL: https://github.com/apache/seatunnel/pull/7928#discussion_r1827134232
##########
plugin-mapping.properties:
##########
@@ -154,3 +154,4 @@ seatunnel.transform.DynamicCompile = seatunnel-transforms-v2
seatunnel.transform.LLM = seatunnel-transforms-v2
seatunnel.transform.Embedding = seatunnel-transforms-v2
seatunnel.transform.RowKindExtractor = seatunnel-transforms-v2
+seatunnel.transform.Explode = seatunnel-transforms-v2
Review Comment:
this change useless now?
##########
docs/en/transform-v2/explode.md:
##########
@@ -0,0 +1,74 @@
+# Explode
Review Comment:
please update the doc.
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/source/converter/SqlToPaimonPredicateConverter.java:
##########
@@ -101,18 +99,15 @@ public static PlainSelect convertToPlainSelect(String
query) {
public static int[] convertSqlSelectToPaimonProjectionIndex(
String[] fieldNames, PlainSelect plainSelect) {
int[] projectionIndex = null;
- List<SelectItem> selectItems = plainSelect.getSelectItems();
+ List<SelectItem<?>> selectItems = plainSelect.getSelectItems();
List<String> columnNames = new ArrayList<>();
for (SelectItem selectItem : selectItems) {
- if (selectItem instanceof AllColumns) {
+ if (selectItem.getExpression() instanceof AllColumns) {
return null;
- } else if (selectItem instanceof SelectExpressionItem) {
- SelectExpressionItem selectExpressionItem =
(SelectExpressionItem) selectItem;
- String columnName =
selectExpressionItem.getExpression().toString();
- columnNames.add(columnName);
} else {
- throw new IllegalArgumentException("Error encountered parsing
query fields.");
+ String columnName = ((Column)
selectItem.getExpression()).getColumnName();
+ columnNames.add(columnName);
Review Comment:
cc @dailai and @TaoZex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
