Hisoka-X commented on code in PR #7928:
URL: https://github.com/apache/seatunnel/pull/7928#discussion_r1832311358
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLFunction.java:
##########
@@ -519,6 +549,8 @@ public Object executeFunctionExpr(String functionName,
List<Object> args) {
return SystemFunction.ifnull(args);
case NULLIF:
return SystemFunction.nullif(args);
+ case ARRAY:
+ return SystemFunction.array(args);
Review Comment:
Please add `array` and `split` method to the doc.
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLFunction.java:
##########
@@ -104,6 +115,7 @@ public class ZetaSQLFunction {
public static final String SUBSTR = "SUBSTR";
public static final String TO_CHAR = "TO_CHAR";
public static final String TRANSLATE = "TRANSLATE";
+ public static final String SPILT = "SPILT";
Review Comment:
```suggestion
public static final String SPLIT = "SPLIT";
```
##########
seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/SQLTransformTest.java:
##########
@@ -165,14 +166,14 @@ public void testEscapeIdentifier() {
ReadonlyConfig.fromMap(
Collections.singletonMap(
"query",
- "select id, trim(`apply`) as `apply` from test
where `apply` = 'a'"));
+ "select id, trim(`apply`,'*') as `apply` from
test where `apply` = 'a*'"));
Review Comment:
The trim method behavior had change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
