liunaijie commented on code in PR #8633:
URL: https://github.com/apache/seatunnel/pull/8633#discussion_r1948303509
##########
seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqOptions.java:
##########
@@ -36,7 +36,7 @@
@Setter
@Getter
@AllArgsConstructor
-public class RabbitmqConfig implements Serializable {
Review Comment:
I think we should split `Config` and `Options` into two classes.
The Options class is used to record the parameters we can pass from the
configuration file (external).
The `RabbitmqConfig` here is a class use to pass parameteres internal.
So, I think we need to split them. Please share your thoughts with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
