liunaijie commented on code in PR #8633:
URL: https://github.com/apache/seatunnel/pull/8633#discussion_r1951829682
##########
seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqOptions.java:
##########
@@ -36,7 +36,7 @@
@Setter
@Getter
@AllArgsConstructor
-public class RabbitmqConfig implements Serializable {
Review Comment:
Let's take a look at this:
[AmazonDynamoDB
Connector](https://github.com/apache/seatunnel/tree/dev/seatunnel-connectors-v2/connector-amazondynamodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/amazondynamodb)
In this connector, we have Options classes (Source, Sink). Each class only
contains the variables that the user can configure in the config file (What I
call `external`).
Additionally, we have a Config class, which is a utility class that helps
pass the user parameters to the DynamoDbSinkClient (What I call `internal`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
