hailin0 commented on code in PR #8734:
URL: https://github.com/apache/seatunnel/pull/8734#discussion_r1958169127
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverter.java:
##########
@@ -248,7 +248,7 @@ public Column convert(BasicTypeDefine typeDefine) {
if (typeDefine.getLength() == null || typeDefine.getLength()
<= 0) {
builder.columnLength(TypeDefineUtils.charTo4ByteLength(1L));
} else {
- builder.columnLength(typeDefine.getLength());
+
builder.columnLength(TypeDefineUtils.charTo4ByteLength(typeDefine.getLength()));
Review Comment:
This length is for binlog parsing, for example: `alert table t1 add column
v1 varchar(1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
