xiaochen-zhou commented on code in PR #8734:
URL: https://github.com/apache/seatunnel/pull/8734#discussion_r1959030251
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverter.java:
##########
@@ -248,7 +248,7 @@ public Column convert(BasicTypeDefine typeDefine) {
if (typeDefine.getLength() == null || typeDefine.getLength()
<= 0) {
builder.columnLength(TypeDefineUtils.charTo4ByteLength(1L));
} else {
- builder.columnLength(typeDefine.getLength());
+
builder.columnLength(TypeDefineUtils.charTo4ByteLength(typeDefine.getLength()));
Review Comment:
> This length is octetLength
>
>
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java#L149
>
>
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeMapper.java#L56
Thank you for the guidance, I will take another look at the code.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverter.java:
##########
@@ -248,7 +248,7 @@ public Column convert(BasicTypeDefine typeDefine) {
if (typeDefine.getLength() == null || typeDefine.getLength()
<= 0) {
builder.columnLength(TypeDefineUtils.charTo4ByteLength(1L));
} else {
- builder.columnLength(typeDefine.getLength());
+
builder.columnLength(TypeDefineUtils.charTo4ByteLength(typeDefine.getLength()));
Review Comment:
> This length is octetLength
>
>
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalog.java#L149
>
>
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeMapper.java#L56
Thank you for the guidance, I will take another look at the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
