liunaijie commented on code in PR #8765:
URL: https://github.com/apache/seatunnel/pull/8765#discussion_r1964868961
##########
seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/local/source/config/LocalFileSourceConfig.java:
##########
@@ -37,7 +36,7 @@ public HadoopConf getHadoopConfig() {
@Override
public String getPluginName() {
- return FileSystemType.LOCAL.getFileSystemPluginName();
+ return "LocalFile";
Review Comment:
This change is not necessary.
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSinkConfig.java:
##########
@@ -35,7 +33,7 @@
import static org.apache.seatunnel.api.sink.DataSaveMode.DROP_DATA;
import static
org.apache.seatunnel.api.sink.DataSaveMode.ERROR_WHEN_DATA_EXISTS;
-public class BaseSinkConfig {
+public class BaseSinkConfig extends FileBaseOptions {
Review Comment:
Suggest we have an unified class name style.
How about rename to
- `FileBaseSinkOptions`
- `FileBaseSourceOptions`
- `FileBaseOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
