liunaijie commented on code in PR #8765:
URL: https://github.com/apache/seatunnel/pull/8765#discussion_r1976795701
##########
seatunnel-connectors-v2/connector-file/connector-file-cos/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/cos/config/CosConfigOptions.java:
##########
@@ -19,9 +19,9 @@
import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;
-import
org.apache.seatunnel.connectors.seatunnel.file.config.BaseSourceConfigOptions;
+import
org.apache.seatunnel.connectors.seatunnel.file.config.FileBaseSourceOptions;
-public class CosConfigOptions extends BaseSourceConfigOptions {
+public class CosConfigOptions extends FileBaseSourceOptions {
Review Comment:
Please also add `CosFileSinkOptions` and `CosFileSource` classes
##########
seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java:
##########
@@ -120,7 +120,11 @@ public void checkConnectorOptionExist() {
||
extendedType
.getNameAsString()
.equals(
-
"IncrementalSource")) {
+
"IncrementalSource")
+ ||
extendedType
+
.getNameAsString()
+
.equals(
+
"BaseMultipleTableFileSink")) {
Review Comment:
please also add `BaseFileSink` and `BaseFileSource` extend class check.
-
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-file/connector-file-cos/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/cos/sink/CosFileSink.java
-
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-file/connector-file-cos/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/cos/source/CosFileSource.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
