Copilot commented on code in PR #8984:
URL: https://github.com/apache/seatunnel/pull/8984#discussion_r2020422255
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/parse/MultipleTableJobConfigParser.java:
##########
@@ -175,21 +194,54 @@ public MultipleTableJobConfigParser(
this.isStartWithSavePoint = isStartWithSavePoint;
this.seaTunnelJobConfig = seaTunnelJobConfig;
this.envOptions =
ReadonlyConfig.fromConfig(seaTunnelJobConfig.getConfig("env"));
+
+ String RefPath =
envOptions.getOptional(EnvCommonOptions.REF_PATH).orElse(null);
+ if (null != RefPath) {
+ this.refMaps = ConfigBuilder.of(Paths.get(RefPath), null);
+ } else {
+ this.refMaps = null;
+ }
+
this.pipelineCheckpoints = pipelineCheckpoints;
}
+ private Config mergeWithRefConfig(Config pluginConfig, Config refConfigs) {
+ if (pluginConfig.hasPath("__st_config_ref_key__ ")) {
+ String refId = pluginConfig.getString("__st_config_ref_key__ ");
Review Comment:
The key '__st_config_ref_key__ ' contains trailing whitespace, which could
lead to mismatches when retrieving configuration values. Consider removing the
trailing space.
```suggestion
if (pluginConfig.hasPath("__st_config_ref_key__")) {
String refId = pluginConfig.getString("__st_config_ref_key__");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
