litiliu commented on code in PR #8984:
URL: https://github.com/apache/seatunnel/pull/8984#discussion_r2015975990
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java:
##########
@@ -173,29 +173,50 @@ private static Config processConfig(
String jsonString =
config.root().render(ConfigRenderOptions.concise());
ObjectNode jsonNodes = JsonUtils.parseObject(jsonString);
Map<String, Object> configMap = JsonUtils.toMap(jsonNodes);
- List<Map<String, Object>> sources =
- (ArrayList<Map<String, Object>>)
configMap.get(Constants.SOURCE);
- List<Map<String, Object>> sinks =
- (ArrayList<Map<String, Object>>) configMap.get(Constants.SINK);
- Preconditions.checkArgument(
- !sources.isEmpty(), "Miss <Source> config! Please check the
config file.");
- Preconditions.checkArgument(
- !sinks.isEmpty(), "Miss <Sink> config! Please check the config
file.");
- sources.forEach(
- source -> {
- for (String sensitiveOption : sensitiveOptions) {
- source.computeIfPresent(sensitiveOption,
processFunction);
- }
- });
- sinks.forEach(
- sink -> {
- for (String sensitiveOption : sensitiveOptions) {
- sink.computeIfPresent(sensitiveOption,
processFunction);
- }
- });
- configMap.put(Constants.SOURCE, sources);
- configMap.put(Constants.SINK, sinks);
- return ConfigFactory.parseMap(configMap);
+ if (configMap.containsKey(Constants.SOURCE)) {
+
+ List<Map<String, Object>> sources =
+ (ArrayList<Map<String, Object>>)
configMap.get(Constants.SOURCE);
+ List<Map<String, Object>> sinks =
+ (ArrayList<Map<String, Object>>)
configMap.get(Constants.SINK);
+ Preconditions.checkArgument(
+ !sources.isEmpty(), "Miss <Source> config! Please check
the config file.");
+ Preconditions.checkArgument(
+ !sinks.isEmpty(), "Miss <Sink> config! Please check the
config file.");
+ sources.forEach(
+ source -> {
+ for (String sensitiveOption : sensitiveOptions) {
+ source.computeIfPresent(sensitiveOption,
processFunction);
+ }
+ });
+ sinks.forEach(
+ sink -> {
+ for (String sensitiveOption : sensitiveOptions) {
+ sink.computeIfPresent(sensitiveOption,
processFunction);
+ }
+ });
+ configMap.put(Constants.SOURCE, sources);
+ configMap.put(Constants.SINK, sinks);
+ return ConfigFactory.parseMap(configMap);
+ } else {
+ Map<String, Map<String, Object>> refMap = new HashMap<>();
+ // get map element in ref
+ for (String key : configMap.keySet()) {
+ Object ref_config = configMap.get(key);
Review Comment:
we should name the variables in the camelcase style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
