Copilot commented on code in PR #9234:
URL: https://github.com/apache/seatunnel/pull/9234#discussion_r2061269988
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/util/MaxcomputeTypeMapper.java:
##########
@@ -272,6 +272,9 @@ private static Object resolveObject2Maxcompute(Object
field, TypeInfo typeInfo)
case CHAR:
return new Char((String) field);
case STRING:
Review Comment:
The conversion logic applies only to LocalDateTime instances, but the test
passes a Timestamp instance. Consider converting Timestamp values to
LocalDateTime (e.g., using toLocalDateTime()) before applying the formatting to
ensure consistent behavior.
```suggestion
case STRING:
if (field instanceof Timestamp) {
field = ((Timestamp) field).toLocalDateTime();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
