Hisoka-X commented on code in PR #9234:
URL: https://github.com/apache/seatunnel/pull/9234#discussion_r2080818768
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/config/MaxcomputeSinkOptions.java:
##########
@@ -46,6 +46,18 @@ public class MaxcomputeSinkOptions extends
MaxcomputeBaseOptions {
public static final Option<String> CUSTOM_SQL =
Options.key("custom_sql").stringType().noDefaultValue().withDescription("custom_sql");
+ public static final Option<String> LOCAL_DATETIME_FORMAT =
+ Options.key("local_datetime_format")
+ .stringType()
+ .defaultValue("yyyy-MM-dd HH:mm:ss")
+ .withDescription("local_datetime_format");
+
+ public static final Option<String> OFFSET_DATETIME_FORMAT =
+ Options.key("offset_datetime_format")
+ .stringType()
+ .defaultValue("yyyy-MM-dd HH:mm:ssXXXXX")
+ .withDescription("offset_datetime_format");
+
Review Comment:
We have same option in
https://github.com/apache/seatunnel/blob/2cc49039f53d99a94e67b675cacd32ec6d8122e3/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/FileBaseSinkOptions.java#L100-L116.
Could you add new common format option in
https://github.com/apache/seatunnel/tree/2cc49039f53d99a94e67b675cacd32ec6d8122e3/seatunnel-api/src/main/java/org/apache/seatunnel/api/options/table
to make sure all same feature use same option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
