Copilot commented on code in PR #9270:
URL: https://github.com/apache/seatunnel/pull/9270#discussion_r2076637361
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/utils/OracleTypeUtils.java:
##########
@@ -69,6 +69,6 @@ public static org.apache.seatunnel.api.table.catalog.Column
convertToSeaTunnelCo
builder.scale(column.length());
}
- return new OracleTypeConverter(false).convert(builder.build());
+ return new OracleTypeConverter(false, false).convert(builder.build());
Review Comment:
The CDC OracleTypeUtils conversion hardcodes handleBlobAsString to false.
Consider exposing this configuration so that the CDC connector's handling of
BLOB data can be aligned with the JDBC connector if needed.
```suggestion
return new OracleTypeConverter(handleBlobAsString,
false).convert(builder.build());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
