Hisoka-X commented on code in PR #9270:
URL: https://github.com/apache/seatunnel/pull/9270#discussion_r2077390943
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeConverter.java:
##########
@@ -202,9 +213,17 @@ public Column convert(BasicTypeDefine typeDefine) {
builder.columnLength(BYTES_4GB - 1);
break;
case ORACLE_BLOB:
- builder.dataType(PrimitiveByteArrayType.INSTANCE);
- // The maximum length of the column is 4GB-1
- builder.columnLength(BYTES_4GB - 1);
+ if (handleBlobAsString) {
+ builder.dataType(BasicType.STRING_TYPE);
+ builder.columnLength(BYTES_4GB - 1);
+ log.info("Converted BLOB to STRING_TYPE with length: {}",
BYTES_4GB - 1);
+ } else {
+ builder.dataType(PrimitiveByteArrayType.INSTANCE);
+ builder.columnLength(BYTES_4GB - 1);
+ log.info(
+ "Converted BLOB to PrimitiveByteArrayType with
length: {}",
+ BYTES_4GB - 1);
+ }
Review Comment:
make sense to me. cc @hailin0 @corgy-w
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
