Hisoka-X commented on code in PR #9642:
URL: https://github.com/apache/seatunnel/pull/9642#discussion_r2251154380


##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisSourceOptions.java:
##########
@@ -51,6 +51,6 @@ public enum HashKeyParseMode {
     public static final Option<String> KEY_FIELD_NAME =
             Options.key("key_field_name")
                     .stringType()
-                    .defaultValue("key")
-                    .withDescription("The value of key you want to write to 
redis.");
+                    .noDefaultValue()

Review Comment:
   > Then I set the appropriate default value conditionally in 
RedisParameters.buildWithConfig().
   
   Ok for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to