dybyte commented on code in PR #9642:
URL: https://github.com/apache/seatunnel/pull/9642#discussion_r2251344663
##########
docs/en/connector-v2/source/Redis.md:
##########
@@ -142,11 +142,26 @@ schema {
### key_field_name [string]
-Specifies the field name to store the Redis key in the output record when
`read_key_enabled = true`.
+Specifies the field name to store the Redis key in the output record when
`read_key_enabled = true` or `data_type = hash`.
Review Comment:
https://github.com/apache/seatunnel/blob/ebc9ee3915fd483f4a61c253f80856d7a7bd60b1/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/source/RedisSourceFactory.java#L70C1-L74C59
When `read_key_enabled = true`, the `key_field_name` option must be
explicitly set due to the required setting. So I believe the default value
`"key"` doesn't actually take effect in this case.
Also, since for other data types the key is not read by default, setting
`"key"` as the default value for `key_field_name` doesn't seem to have any
practical effect.
Would it be okay to remove the default `"key"` value entirely? If so, I
believe there's nothing else that needs to be added to the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
