zhangshenghang commented on code in PR #9749:
URL: https://github.com/apache/seatunnel/pull/9749#discussion_r2295096070
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -681,6 +681,9 @@ && getJobHistoryService().getJobMetrics(jobId)
} else {
runningJobInfoIMap.remove(jobId);
runningJobMasterMap.remove(jobId);
+ // remove jobId from pendingJobMasterMap when
jobSubmitFuture is
+ // exceptionally.
+ pendingJobMasterMap.remove(jobId);
Review Comment:
Your suggestions make sense. Enhancing PeekBlockingQueue to handle both
functions or introducing a PendingJobManager to encapsulate them would avoid
inconsistent clearing and boost maintainability. Either approach works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
