hawk9821 commented on code in PR #9749:
URL: https://github.com/apache/seatunnel/pull/9749#discussion_r2296104413


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -656,11 +652,10 @@ && getJobHistoryService().getJobMetrics(jobId)
                                             "The job id %s has already been 
submitted and is not starting with a savepoint.",
                                             jobId));
                         }
-                        pendingJobMasterMap.put(
-                                jobId, new Tuple2<>(PendingSourceState.SUBMIT, 
jobMaster));
                         runningJobInfoIMap.put(
                                 jobId,
                                 new JobInfo(System.currentTimeMillis(), 
jobImmutableInformation));
+                        runningJobMasterMap.put(jobId, jobMaster);

Review Comment:
   I see. The `runningJobMasterMap.put(jobId, finalJobMaster)` should be 
executed at the `jobMaster.run` position, and the one here is redundant and 
should be deleted.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to