dyp12 commented on code in PR #9735:
URL: https://github.com/apache/seatunnel/pull/9735#discussion_r2295498908
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/source/offset/BinlogOffsetFactory.java:
##########
@@ -76,6 +76,7 @@ public Offset specific(String filename, Long position) {
@Override
public Offset timestamp(long timestamp) {
- throw new UnsupportedOperationException("not supported create new
Offset by timestamp.");
+ // mysql binlog timestamp is second, so we need to divide 1000
Review Comment:
> so why we should `/ 1000`?
https://github.com/apache/seatunnel/pull/9735/files/f780aa68a6e524e1401734506fbb5d867176c293
the timestamp is milliseconds, but in BinlogOffset timestamp is second. so
/1000 make milliseconds to second
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
