dyp12 commented on code in PR #9735:
URL: https://github.com/apache/seatunnel/pull/9735#discussion_r2297366081


##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/utils/MySqlConnectionUtils.java:
##########
@@ -185,4 +192,87 @@ private static Map<String, String> querySystemVariables(
 
         return variables;
     }
+
+    public static BinlogOffset findBinlogOffsetBytimestamp(
+            JdbcConnection jdbc, BinaryLogClient client, long timestamp) {
+        final String showBinaryLogStmt = "SHOW BINARY LOGS";

Review Comment:
   > @dyp12 We should support 8.4 too. Please refer 
[e338743#diff-a059ddeb198852981f568a6087e543c358b90c5116cd918bcdf07c32e4008324R77](https://github.com/apache/seatunnel/commit/e338743927c20a3c43073b4b069afd6bd644905d#diff-a059ddeb198852981f568a6087e543c358b90c5116cd918bcdf07c32e4008324R77)
   
   fixed it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to