Hisoka-X commented on code in PR #9946:
URL: https://github.com/apache/seatunnel/pull/9946#discussion_r2443015501
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-redis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java:
##########
@@ -610,14 +633,24 @@ public void
testCustomHashKeyAndValueWriteRedis(TestContainer container)
jedis.del("custom-hash-check");
}
- @TestTemplate
- public void testFakeToRedisDeleteHashTest(TestContainer container)
- throws IOException, InterruptedException {
- Container.ExecResult execResult =
- container.executeJob("/fake-to-redis-test-delete-hash.conf");
- Assertions.assertEquals(0, execResult.getExitCode());
- Assertions.assertEquals(2, jedis.hlen("hash_check"));
- jedis.del("hash_check");
+ @Test
+ public void testFakeToRedisDeleteHashTest() throws IOException {
Review Comment:
Please reuse
https://github.com/apache/seatunnel/blob/720ed0c756a483b096c43ecdd752499f09927ff5/seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/sink/SinkFlowTestUtils.java#L41,
we already has this tool to verify sink by unit test.
Also you refer some demo
https://github.com/apache/seatunnel/blob/720ed0c756a483b096c43ecdd752499f09927ff5/seatunnel-connectors-v2/connector-file/connector-file-local/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/local/LocalFileTest.java#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
