chl-wxp commented on code in PR #9946:
URL: https://github.com/apache/seatunnel/pull/9946#discussion_r2464329742
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-redis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java:
##########
@@ -98,12 +115,20 @@ public void startUp() {
.withNetwork(NETWORK)
.withNetworkAliases(host)
.withExposedPorts(port)
+ .withCreateContainerCmdModifier(
+ cmd ->
+ cmd.getHostConfig()
+ .withPortBindings(
+ new PortBinding(
+
Ports.Binding.bindPort(port),
+ new
ExposedPort(port))))
Review Comment:
> I noticed that the test container now forces Redis to bind host port 6379
and still passes that literal port into ReadonlyConfig. That’s fragile—any
local/CI process already listening on 6379 will make the container fail to
start, taking the whole Redis suite down. Could you drop the custom
port-binding block and switch the test config to use
redisContainer.getFirstMappedPort() instead? That keeps the sink test stable
across environments.
What was missed during the testing process has been deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
