xiaochen-zhou commented on code in PR #10011:
URL: https://github.com/apache/seatunnel/pull/10011#discussion_r2488887821
##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/config/HbaseSourceOptions.java:
##########
@@ -34,6 +34,20 @@ public class HbaseSourceOptions extends HbaseBaseOptions {
.noDefaultValue()
.withDescription("Hbase scan end rowkey");
+ public static final Option<Boolean> START_ROW_INCLUSIVE =
+ Options.key("start_row_inclusive")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ "Whether to include the start row in the scan.
Default is true (inclusive).");
+
+ public static final Option<Boolean> END_ROW_INCLUSIVE =
Review Comment:
In order to maintain consistency with the previous logic, i think the
default value of `end_row_inclusive` should also be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
