Carl-Zhou-CN commented on code in PR #10011:
URL: https://github.com/apache/seatunnel/pull/10011#discussion_r2499107517
##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/config/HbaseSourceOptions.java:
##########
@@ -34,6 +34,20 @@ public class HbaseSourceOptions extends HbaseBaseOptions {
.noDefaultValue()
.withDescription("Hbase scan end rowkey");
+ public static final Option<Boolean> START_ROW_INCLUSIVE =
+ Options.key("start_row_inclusive")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ "Whether to include the start row in the scan.
Default is true (inclusive).");
+
+ public static final Option<Boolean> END_ROW_INCLUSIVE =
Review Comment:
I think the intended result of the configuration should be to control
whether the boundaries are included. However, I believe that when both sides
are set to false, it will result in shards like (start, 1), (1, 3), (3, end),
which causes the loss of boundary data. Conversely, it will lead to duplicate
boundary data. Instead of adjusting the boundaries of each split, we should
only modify the inclusion settings of the start and end points
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
