Mrhs121 commented on code in PR #10060:
URL: https://github.com/apache/seatunnel/pull/10060#discussion_r2536072695


##########
seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/sink/writer/DorisStreamLoad.java:
##########
@@ -222,6 +224,7 @@ private RespContent 
handlePreCommitResponse(CloseableHttpResponse response) thro
 
     public RespContent stopLoad() throws IOException {
         loading = false;
+        flushing = true;

Review Comment:
   FYI, you can take a look at the description of root cause first 
https://github.com/apache/seatunnel/issues/10059#issue-3619248324.  
   
   As shown in the following code, the error msg in the http response will only 
be obtained when it is in the loading state, and this `loading` will be reset 
to `false` during flush. Therefore, if the flush action is executed before the 
http response is returned. This means that `errorMessage` will always be 
`null`, an infinite loop occurs, preventing the seatunnel task from stopping.
   
   
https://github.com/apache/seatunnel/blob/de9085d907fffb4ece5ce07cbf0adbdff7467ff9/seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/sink/writer/DorisStreamLoad.java#L194-L210



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to