Mrhs121 commented on code in PR #10060:
URL: https://github.com/apache/seatunnel/pull/10060#discussion_r2592433803
##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-3.3/src/main/java/org/apache/seatunnel/translation/spark/sink/write/SeaTunnelSparkDataWriter.java:
##########
@@ -92,8 +92,6 @@ public WriterCommitMessage commit() throws IOException {
SeaTunnelSparkWriterCommitMessage<CommitInfoT>
seaTunnelSparkWriterCommitMessage =
new SeaTunnelSparkWriterCommitMessage<>(latestCommitInfoT);
cleanCommitInfo();
- sinkWriter.close();
- context.getEventListener().onEvent(new WriterCloseEvent());
Review Comment:
It looks like this snippet was copied from the Spark 2 template and the
author missed the subtle difference: DataWriter interface in Spark 2 doesn’t
implement Closeable, so close it manually here.，(￢_￢)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
