zhangshenghang commented on code in PR #10075:
URL: https://github.com/apache/seatunnel/pull/10075#discussion_r2589173155
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -882,7 +888,7 @@ public void savePipelineMetricsToHistory(PipelineLocation
pipelineLocation) {
this.getCurrJobMetrics(Collections.singletonList(pipelineLocation));
JobMetrics jobMetrics = JobMetricsUtil.toJobMetrics(currJobMetrics);
long jobId = this.getJobImmutableInformation().getJobId();
- synchronized (this) {
+ synchronized (metricsLock) {
jobHistoryService.storeFinishedPipelineMetrics(jobId, jobMetrics);
}
Review Comment:
> I'm not sure why this logic needs to be mutually exclusive with
stopJob/cancelJob. Could you please clarify the reason?
I'm describing its previous logic, and I want to confirm if making such a
modification will have any other impacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
