thehkkim commented on PR #10335: URL: https://github.com/apache/seatunnel/pull/10335#issuecomment-3757778053
@zhangshenghang Thank you for the detailed review! I've fixed all the critical issues: **[P0] Header fields with null values are permanently lost (COR-001)** - ✅ Fixed by writing "null" string instead of skipping null values - This is now consistent with partition_key_fields behavior **[MAJOR] No overlap validation between partition_key_fields and kafka_headers_fields (GEN-001)** - ✅ Added validation to reject overlapping fields - Implemented check in KafkaSinkWriter.java that throws exception if same field appears in both configs **[MINOR] NATIVE format silently ignores kafka_headers_fields (GEN-002)** - ✅ Added validation to reject kafka_headers_fields config for NATIVE format - Now throws clear error message: "kafka_headers_fields is not supported with NATIVE format" - Users will see error instead of silent failure All changes have been tested. Ready for re-review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
