thehkkim commented on PR #10335: URL: https://github.com/apache/seatunnel/pull/10335#issuecomment-3864388274
@dybyte Thanks for the review! I’ve updated the code accordingly: 1. Replaced CommonErrorCodeDeprecated with CommonErrorCode. 2. Followed the suggestion to keep header values as null instead of converting them to the literal "null" string, since converting null to "null" distorts the actual data and makes it indistinguishable from a real "null" value. 3. Updated the empty-check logic from `return kafkaHeaders.toArray().length > 0 ? kafkaHeaders : null;` to `return kafkaHeaders.iterator().hasNext() ? kafkaHeaders : null;` These changes have been committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
